-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse log plugin topics using new mqtt schema #2305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruadhri17
had a problem deploying
to
Test Pull Request
September 29, 2023 09:01 — with
GitHub Actions
Failure
Codecov Report
Additional details and impacted files
|
albinsuresh
approved these changes
Sep 29, 2023
} | ||
|
||
pub struct LogManagerOptions { | ||
pub config_dir: PathBuf, | ||
pub mqtt_topic_root: Arc<str>, | ||
pub mqtt_device_topic_id: Arc<str>, | ||
pub mqtt_topic_root: MqttSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
pub mqtt_topic_root: MqttSchema, | |
pub mqtt_schema: MqttSchema, |
Robot Results
|
rina23q
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ruadhri17
temporarily deployed
to
Test Pull Request
September 29, 2023 10:17 — with
GitHub Actions
Inactive
Ruadhri17
force-pushed
the
log-plugin-mqtt-schema
branch
from
October 5, 2023 08:47
4c9849e
to
e4b2012
Compare
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
Ruadhri17
force-pushed
the
log-plugin-mqtt-schema
branch
from
October 5, 2023 08:49
e4b2012
to
faac8d9
Compare
Ruadhri17
had a problem deploying
to
Test Pull Request
October 5, 2023 08:59 — with
GitHub Actions
Failure
Ruadhri17
temporarily deployed
to
Test Pull Request
October 6, 2023 09:04 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace previous log plugin topics parsing with the Mqtt schema. Additionally this PR removes
current_operations
field that is not used after #2108 changes.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments