Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse log plugin topics using new mqtt schema #2305

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

Ruadhri17
Copy link
Contributor

Proposed changes

Replace previous log plugin topics parsing with the Mqtt schema. Additionally this PR removes current_operations field that is not used after #2108 changes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #2305 (faac8d9) into main (5a52630) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Additional details and impacted files
Files Coverage Δ
crates/extensions/tedge_log_manager/src/tests.rs 92.1% <ø> (-0.1%) ⬇️
crates/extensions/tedge_log_manager/src/actor.rs 69.5% <0.0%> (+0.3%) ⬆️
plugins/tedge_log_plugin/src/lib.rs 0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/config.rs 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

}

pub struct LogManagerOptions {
pub config_dir: PathBuf,
pub mqtt_topic_root: Arc<str>,
pub mqtt_device_topic_id: Arc<str>,
pub mqtt_topic_root: MqttSchema,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub mqtt_topic_root: MqttSchema,
pub mqtt_schema: MqttSchema,

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
301 0 3 301 100 47m55.77s

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ruadhri17 Ruadhri17 temporarily deployed to Test Pull Request September 29, 2023 10:17 — with GitHub Actions Inactive
@Ruadhri17 Ruadhri17 force-pushed the log-plugin-mqtt-schema branch from 4c9849e to e4b2012 Compare October 5, 2023 08:47
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
@Ruadhri17 Ruadhri17 force-pushed the log-plugin-mqtt-schema branch from e4b2012 to faac8d9 Compare October 5, 2023 08:49
@Ruadhri17 Ruadhri17 temporarily deployed to Test Pull Request October 6, 2023 09:04 — with GitHub Actions Inactive
@Ruadhri17 Ruadhri17 merged commit c6e0126 into thin-edge:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants