Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-udeps: pin nightly version to fix "unknown feature stdsimd" error #2687

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Bravo555
Copy link
Contributor

@Bravo555 Bravo555 commented Feb 6, 2024

Proposed changes

Pin nightly version so cargo-udeps keeps working. After our dependencies are updated and don't use the incompatible ahash version, the pin can be removed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good quick fix as a short time solution 👍

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3eb394) 75.9% compared to head (4347525) 75.9%.
Report is 20 commits behind head on main.

❗ Current head 4347525 differs from pull request most recent head 953a1ff. Consider uploading reports for the commit 953a1ff to get more accurate results

Additional details and impacted files

see 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
390 0 3 390 100 59m59.891999999s

@reubenmiller reubenmiller added this pull request to the merge queue Feb 6, 2024
Merged via the queue into thin-edge:main with commit 381f88e Feb 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants