Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(riscv): building using Rust 1.73 to avoid segmentation fault in release mode #2785

Merged
merged 1 commit into from
Mar 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ jobs:
- armv5te-unknown-linux-musleabi
- x86_64-unknown-linux-musl
- i686-unknown-linux-musl
- riscv64gc-unknown-linux-gnu
- x86_64-apple-darwin
mode:
- --release
Expand Down Expand Up @@ -91,6 +90,13 @@ jobs:
cargo_options: --no-run

- target: riscv64gc-unknown-linux-gnu
mode: '--release'
# Using < 1.73 causes a segmentation fault when running a binary built with the --release flag
# Rust 1.73 includes both an updated llvm version and updated binutils which is like to have improved compatibility
# See: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1730-2023-10-05
# There is a comment in the https://github.com/rust-lang/rust/pull/114048/ which refers to riscv64 support:
# * "Updated dist-riscv64-linux to use binutils 2.36 in order to recognize the zicsr feature, which is no longer part of the base ISA."
rust_channel: "1.73"
host_os: ubuntu-22.04
cargo_options: --no-run

Expand Down
Loading