-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use loopback ip address instead of alias to improve compatibility #2952
feat: use loopback ip address instead of alias to improve compatibility #2952
Conversation
Robot Results
|
Ok, seems like the mosquitto TLS cert generation might need to change to also support TLS connections when using the loopback address, currently it only supports the hostname, or Update Addressed by 05ca442 |
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
…certs for localhost Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
05ca442
to
e54f81a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Proposed changes
Some Linux distributions installations where the
/etc/hosts
file is not defined, the loopback address (127.0.0.1
), thelocalhost
alias does not get resolved to127.0.0.1
. And devices which have a read-only rootfs, can't even add a manual entry to the list, so the only option is to change thetedge.toml
values (which is not ideal for such basic settings).Changing the defaults from
localhost
to127.0.0.1
improves the out of the box compatibility.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments