-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use direct c8y connection for c8y-remote-access-plugin #3006
feat: use direct c8y connection for c8y-remote-access-plugin #3006
Conversation
Robot Results
|
@jarhodes314 Can you please review this PR. Thanks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
I've pushed some system tests, but don't be surprised if there are a few failures as the remote access has a few dependencies (e.g. generate ssh keypair, install go-c8y-cli, calling go-c8y-cli to create the passthrough configuration, and then run the ssh command). |
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
6e7b5e9
to
2d897d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added Test Step is OK, however having in mind that this test has additional test steps comming from #3007 I will do the more detail check in that PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the OG commit that's being reverted, but I don't see anything wrong.
LGTM |
Proposed changes
Remove the c8y-remote-access-plugin connection dependency on the c8y local proxy which is launched by the tedge-mapper-c8y service. This is part one of the large ticket (#2859) which looks at creating the remote access connection which is fully independent to the tedge-mapper-c8y service, thus allowing the user to execute
tedge reconnect c8y
without the remote access connection from being dropped.Note
Prior to the c8y local proxy feature, the c8y-remote-access-plugin did use a direct connection to Cumulocity IoT, however the implementation was switch to use the local proxy which adds an additional connection dependency on the tedge-mapper-c8y (e.g. if you restart the tedge-mapper-c8y, the local proxy will also restart thus stopping the connection). This PR does not change the fact that there is still a process dependency between the spawned c8y-remote-access-plugin instance and the tedge-mapper-c8y service, however this will be addressed via #3007
The PR is based on reverting the c8y local proxy commit: 845480e
Types of changes
Paste Link to the issue
#2859
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments