-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: check compatibility of thin-edge.io with Cumulocity IoT basic auth device users and SmartREST 1.0 #3039
POC: check compatibility of thin-edge.io with Cumulocity IoT basic auth device users and SmartREST 1.0 #3039
Conversation
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
9ca8f4a
to
d9aa6b1
Compare
]; | ||
|
||
let use_legacy_auth = remote_username.is_some() && remote_password.is_some(); | ||
if use_legacy_auth { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic should be opposite. If use_legacy_auth
== true
, not adding JWT token topics to bridge.
if use_legacy_auth { | |
if !use_legacy_auth { |
Question: Do we even have to change the bridge file as per auth method? If mapper doesn't subscribe to JWT token, isn't it enough? I mean the bridge still maps the JWT tokens c8y/
, but no actor subscribes to the JWT topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think it still needs to be conditional because otherwise an error message is published on the s/e topic
Closing as this has been implemented in #3196 |
Proposed changes
Proof of concept / validation, that if thin-edge.io would support Cumulocity IoT's basic auth device users (e.g. not cert based authentication), would enable usage of SmartREST 1.0 to allow existing SmartREST 1.0 users the ability to even use thin-edge.io (which manages the cloud connection and provides a usable local Cumulocity IoT proxy)
The following items are included in the POC.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments