Add AWS keywords and create test for connecting thinedge to AWS using keys for authentication #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keys Signed-off-by: gligorisaev <gligorisaev@gmail.com>
gligorisaev
requested review from
reubenmiller,
albinsuresh,
jarhodes314 and
a team
as code owners
gligorisaev
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
| { | ||
| "Effect": "Allow", | ||
| "Action": "iot:Connect", | ||
| "Resource": "arn:aws:iot:us-east-1:227890699892:client/${iot:Connection.Thing.ThingName}" |
There was a problem hiding this comment.
The region and client id should not be hardcoded.
There was a problem hiding this comment.
Actually I work now on a solution not to have a file at all, I want to avoid the need of maintaining a file
Comment on lines
28
to
29
| #Check addapter and run only if adapter is ssh | ||
| Run Command If SSH Adapter |
There was a problem hiding this comment.
Why such a restriction?
There was a problem hiding this comment.
One of the differences of the "Setup" keyword wtih different adapter used is that in case of adapter=Docker (adapter: None is default, which is Docker) Setup is bootstrapping and making a fresh instalation, creating certificate etc. In case of adapter=ssh it is not
…full connection Signed-off-by: gligorisaev <gligorisaev@gmail.com>
gligorisaev
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
gligorisaev
had a problem deploying
to
Test Auto
GitHub Actions
Failure
Robot Results
Failed Tests
|
Signed-off-by: gligorisaev <gligorisaev@gmail.com>
gligorisaev
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
… for c8y Signed-off-by: gligorisaev <gligorisaev@gmail.com>
gligorisaev
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
|
@gligorisaev Since this is AWS specific functionality it might make more sense creating a dedicated |
|
This is superseded by #3097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New keywords are added to the ThinEdgeIO Robot Framework Library
Create Session With Keys- Creates an AWS session using the provided access key, secret key, and optional region.Create New Policy- Creates a new IoT policy with the provided name and reads the policy document from a file.Register Device- Registers a new IoT Thing with the provided device ID.Check Policy Exists- Checks if the specified IoT policy exists.Check Device Exists- Checks if the specified IoT device (thing) exists.Configure Device- Configures the device by creating keys and certificates, attaching the policy to the certificate,Teardown AWS Resources- Deletes the created IoT policy and the registered device (thing) in AWS IoT Core.Test Case created: tests/RobotFramework/tests/aws/aws_coonect_with_keys.robot
Description:
This test case validates the ability of thin-edge.io to successfully connect to AWS IoT Core. The test ensures that the necessary AWS credentials are available in the .env file and that the AWS IoT Core environment is correctly configured.
Preconditions:
AWS credentials:
AWS_URLAWS_ACCESS_KEYAWS_SECRET_KEYAWS_REGIONmust be provided in the .env file.
The test also support SSH adapter to be used.
Test Steps:
Suite Setup:
Custom setup is executed, which includes setting up the device serial number and configuring the AWS IoT Core URL.
Teardown:
Custom teardown is performed, which includes removing the created resources from AWS IoT Core, deleting the certificate files from the device, and retrieving logs.
Tags:
theme:aws
test:on_demand
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments