Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: format code and add ci check for robotframework formatting #3129

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Run just format to apply the formatting to the code base due to:

  • Latest Rustfmt nightly results in new formatting
  • Some Robotframework tests weren't formattinged before

To avoid committing unformatted Robotframework tests, the format-check was extended to also check the formatting of the Robotframework tests as well which is run on PR checks.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Comment on lines +164 to +167
type Read<'a>
= File
where
Self: 'a;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... cargo-fmt pushing too far.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. And I always forget to do a rustup update to update all of the Rust components, so it took me awhile to actually run the required version of Rustfmt

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
505 0 2 505 100 1h28m40.613242999s

@reubenmiller reubenmiller added this pull request to the merge queue Sep 23, 2024
Merged via the queue into thin-edge:main with commit 6527404 Sep 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics theme:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants