Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for building against specific gnu libc versions #3175

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Oct 8, 2024

Proposed changes

Adjust the build.sh script to accept targets with the gnu libc version as a suffix.

This is a feature of cargo-zigbuild (see https://github.com/rust-cross/cargo-zigbuild?tab=readme-ov-file#specify-glibc-version). It is only intended for testing and experiments. It does not change the way the official binaries are built!

Examples

just release aarch64-unknown-linux-gnu.2.17

just release aarch64-unknown-linux-gnu.2.27

just release aarch64-unknown-linux-gnu.2.30

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

…go-ziglang (for testing/experiments only)

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller changed the title build: add support for building against specific gnu libc versions using cargo-ziglang (for testing/experiments only) build: add support for building against specific gnu libc versions Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h44m27.556103999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Oct 9, 2024
Merged via the queue into thin-edge:main with commit daef5e3 Oct 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants