-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integration with Cumulocity CA #3259
base: main
Are you sure you want to change the base?
feat: Integration with Cumulocity CA #3259
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
) | ||
} | ||
} | ||
warning!("Will retry in 5 seconds"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One needs to loop only when it makes senses to retry: i.e. the c8y endpoint has been reached but the device has not been registered yet.
Question: does Cumulocity return a specific HTTP status when the device is not registered?
844dc34
to
284c8ee
Compare
284c8ee
to
fba8ed6
Compare
5f284b5
to
5335af8
Compare
Robot Results
|
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
8ee9b20
to
abfa57e
Compare
Proposed changes
Types of changes
Paste Link to the issue
#3248
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments