Increase internal buffer size #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate current changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests includes the necessary code changes to increase the internal buffer size to
size_tinstead ofuint16_tallowing for sending much bigger data packets at once than previously.Tested on ESP32 sending / receiving data still works correctly.
The only thing else that is needed is to increase the passable buffer size on the ThingsBoard side to size_t as well.
Version numbers have already been increased to
2.9.2. Would be nice if this could be merged @imbeacon and the Arduino library repository and Plattformio Repository updated accordingly.