ws-client: revert autocomplete in forms

thingsboard · Mar 19, 2024 · 02e199c · 02e199c
1 parent 5064077
commit 02e199c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/...x/src/app/modules/home/components/client-credentials-templates/basic/basic.component.html b/...x/src/app/modules/home/components/client-credentials-templates/basic/basic.component.html
@@ -21,7 +21,7 @@
     <div class="tb-hint" innerHTML="{{ 'mqtt-client-credentials.hint-credentials-type-basic' | translate }}"></div>
     <mat-form-field class="mat-block">
       <mat-label translate>mqtt-client.client-id</mat-label>
-      <input matInput formControlName="clientId" name="client-id">
+      <input matInput formControlName="clientId">
       <tb-copy-button [fxShow]="credentialsMqttFormGroup.get('clientId')?.value?.length" matSuffix
                       [copyText]="credentialsMqttFormGroup.get('clientId').value">
       </tb-copy-button>

diff --git a/ui-ngx/src/app/modules/home/components/wizard/connection-wizard-dialog.component.html b/ui-ngx/src/app/modules/home/components/wizard/connection-wizard-dialog.component.html
@@ -37,7 +37,7 @@ <h2 translate>{{ title }}</h2>
       <mat-icon>check</mat-icon>
     </ng-template>
     <mat-step [stepControl]="connectionFormGroup">
-      <form [formGroup]="connectionFormGroup" #conFormGroup="ngForm" autocomplete="off">
+      <form [formGroup]="connectionFormGroup" #conFormGroup="ngForm">
         <ng-template matStepLabel>{{ 'ws-client.connections.connection-details' | translate}}</ng-template>
         <mat-form-field class="mat-block">
           <mat-label translate>ws-client.connections.name</mat-label>
@@ -101,7 +101,7 @@ <h2 translate>{{ title }}</h2>
               </mat-form-field>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.client-id</mat-label>
-                <input matInput formControlName="clientId" name="client-id-auto">
+                <input matInput formControlName="clientId">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('clientId')?.value?.length"
                                 [copyText]="connectionFormGroup.get('clientId')?.value">
@@ -114,7 +114,7 @@ <h2 translate>{{ title }}</h2>
               </mat-form-field>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.username</mat-label>
-                <input matInput formControlName="username" name="user-name-auto">
+                <input matInput formControlName="username">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('username')?.value?.length"
                                 [copyText]="connectionFormGroup.get('username')?.value">
@@ -130,23 +130,23 @@ <h2 translate>{{ title }}</h2>
             <ng-template [ngSwitchCase]="wsCredentialsGeneratorType.CUSTOM">
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.client-id</mat-label>
-                <input matInput formControlName="clientId" name="client-id-custom">
+                <input matInput formControlName="clientId">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('clientId')?.value?.length"
                                 [copyText]="connectionFormGroup.get('clientId')?.value">
                 </tb-copy-button>
               </mat-form-field>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.username</mat-label>
-                <input matInput name="user-name-custom" formControlName="username">
+                <input matInput formControlName="username">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('username')?.value?.length"
                                 [copyText]="connectionFormGroup.get('username')?.value">
                 </tb-copy-button>
               </mat-form-field>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.password</mat-label>
-                <input matInput name="new-password" autocomplete="off" formControlName="password" type="password">
+                <input matInput autocomplete="new-password" formControlName="password" type="password">
                 <tb-toggle-password matSuffix></tb-toggle-password>
               </mat-form-field>
             </ng-template>
@@ -163,7 +163,7 @@ <h2 translate>{{ title }}</h2>
               </section>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.client-id</mat-label>
-                <input matInput formControlName="clientId" name="client-id-existing">
+                <input matInput formControlName="clientId">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('clientId')?.value?.length"
                                 [copyText]="connectionFormGroup.get('clientId')?.value">
@@ -176,15 +176,15 @@ <h2 translate>{{ title }}</h2>
               </mat-form-field>
               <mat-form-field class="mat-block">
                 <mat-label translate>ws-client.connections.username</mat-label>
-                <input matInput formControlName="username" name="un-existing">
+                <input matInput formControlName="username">
                 <tb-copy-button matSuffix
                                 [fxShow]="connectionFormGroup.get('username')?.value?.length"
                                 [copyText]="connectionFormGroup.get('username')?.value">
                 </tb-copy-button>
               </mat-form-field>
               <mat-form-field class="mat-block" [fxShow]="passwordRequired">
                 <mat-label translate>ws-client.connections.password</mat-label>
-                <input matInput name="new-password" autocomplete="off" formControlName="password" type="password">
+                <input matInput autocomplete="new-password" formControlName="password" type="password">
                 <tb-toggle-password matSuffix></tb-toggle-password>
                 <button matSuffix mat-icon-button type="button" [matTooltip]="'ws-client.connections.password-warning' | translate">
                   <mat-icon style="color: #ff9a00">warning</mat-icon>

diff --git a/.../pages/shared-subscription-groups/shared-subscription-groups-filter-config.component.html b/.../pages/shared-subscription-groups/shared-subscription-groups-filter-config.component.html
@@ -59,13 +59,13 @@
     <div class="tb-form-row space-between column-xs">
       <div class="fixed-title-width" translate>shared-subscription.share-name</div>
       <mat-form-field class="flex" appearance="outline" subscriptSizing="dynamic">
-        <input matInput name="share-name" type="text" style="max-width: 200px;" formControlName="shareNameSearch">
+        <input matInput type="text" style="max-width: 200px;" formControlName="shareNameSearch">
       </mat-form-field>
     </div>
     <div class="tb-form-row space-between column-xs">
       <div class="fixed-title-width" translate>shared-subscription.topic-filter</div>
       <mat-form-field class="flex" appearance="outline" subscriptSizing="dynamic">
-        <input name="topic-filter" matInput type="text" style="max-width: 200px;" formControlName="topicFilter">
+        <input matInput type="text" style="max-width: 200px;" formControlName="topicFilter">
       </mat-form-field>
     </div>
     <div class="tb-form-row space-between column-xs">

diff --git a/ui-ngx/src/app/modules/home/pages/ws-client/connections/connection-controller.component.html b/ui-ngx/src/app/modules/home/pages/ws-client/connections/connection-controller.component.html
@@ -38,7 +38,7 @@
   <section fxLayout="row" fxLayoutGap="16px">
     <mat-form-field *ngIf="isPasswordRequired && !reconnecting" appearance="outline" subscriptSizing="dynamic">
       <mat-label translate>mqtt-client-credentials.password</mat-label>
-      <input matInput name="new-password" [(ngModel)]="password" [type]="!isPasswordVisible ? 'password' : 'text'" required>
+      <input matInput [(ngModel)]="password" [type]="!isPasswordVisible ? 'password' : 'text'" required>
       <button mat-icon-button matSuffix (click)="isPasswordVisible = !isPasswordVisible"
               class="tb-mat-20" [attr.aria-label]="'Hide password'" [attr.aria-pressed]="!isPasswordVisible">
         <mat-icon>{{ isPasswordVisible ? 'visibility' : 'visibility_off' }}</mat-icon>