Fixing Library for Arduino Boards #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imbeacon Would be nice if this could be merged and released as |
|
@imbeacon Would be nice if this could be released on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the library and it's examples for boards that do not support the C++ STL, like Arduino Uno or AVR Mega.
OTA should now be compatible with Arduino boards and examples compile again, closes #232, closes #233.
Fixes not null-terminated Topic string on ESP-IDF framework, closes #237.
Adjust api to breaking changes in underlying TBPubSubClient. And add it to the dependencies so it is guaranteed to be installed with the correct version.
Additionally
ArduinoHTTPClientandUpdateis now also automatically installed, but only if the Arduino framework is used. This makes using the library easier for future users, because now nearly every user does not need to include any additional dependecnies, when using this library.@imbeacon would be nice if this could be released as
v0.15.0.