Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An importer for ica.se (Swedish storechain) #715

Merged
merged 1 commit into from
Apr 20, 2013
Merged

An importer for ica.se (Swedish storechain) #715

merged 1 commit into from
Apr 20, 2013

Conversation

MrShark
Copy link
Contributor

@MrShark MrShark commented Apr 11, 2013

A simple importer for web pages.

The recepies are marked up using a microformat from http://schema.org/Recipe so the parser should be extendible to parse more sites. I will try to do this later, but for now I haven't had the time to find more sites and try them.

There is a hack to set the image for the recipe based on parsing that should be removed later, but that needs an interface in WebParser to set the image.

ockham added a commit that referenced this pull request Apr 20, 2013
An importer for ica.se (Swedish storechain)
@ockham ockham merged commit 228706e into thinkle:master Apr 20, 2013
@ockham
Copy link
Collaborator

ockham commented Apr 20, 2013

Looks good and seems to work fine, merging. Thank you for your contribution! A couple of notes:

  • That ica.se website seems to support a couple more recipe schema tags, such as rating and description, which we might want to use, too (description could go into our modifications field).
  • Recipe importers make a good case for our need for automatic (unit) tests: we should supply an example URL for processing (or better yet, provide an example HTML file and image) and test if the import works correctly.

Tell me if you feel like tackling any of these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants