Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default redis config, which can cause permanent WSOD on pantheon #9

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

wxactly
Copy link
Member

@wxactly wxactly commented Sep 2, 2022

Proposal to delete this default code. Open to other ideas though! I expected to be able to enable Redis on the Pantheon dashboard without any consequences, but here's what happened on my site:

  1. I enabled Redis on the pantheon dashboard
  2. All sites started showing WSOD
  3. I panicked
  4. I disabled Redis on the pantheon dashboard
  5. All sites continued to show WSOD

I believe this is because Pantheon leaves the $conf['redis_client_host'] setting even after Redis has been disabled, but I honestly couldn't confirm that while panicking...

@wxactly wxactly requested review from mariacha and unclegcb September 2, 2022 18:58
@mariacha
Copy link
Collaborator

mariacha commented Sep 2, 2022

This happens when the Redis module isn't installed or enabled on the site. It's definitely dangerous to have in for the reason you've described. I'll take it out, but I wish there were a way to check to see if the module is enabled before pulling in this code, but I haven't seen an answer to that.

But it's probably better to have Redis turned on and not working than it is to have Redis not turned on and a WSOD, so I'll turn this into a backlog ticket and think about it again.

@mariacha mariacha merged commit 7620839 into main Sep 2, 2022
@mariacha mariacha mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants