fix glyph alignment problem #20
Conversation
yhfudev
commented
Dec 21, 2016
yhfudev
commented
- fix glyph alignment problem
- update the default charset to 0-255(unicode) to cover more languages by default.
|
That's looking promising. |
| @@ -1265,7 +1270,7 @@ | |||
| // RepRapDiscount FULL GRAPHIC Smart Controller | |||
| // http://reprap.org/wiki/RepRapDiscount_Full_Graphic_Smart_Controller | |||
| // | |||
| //#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER | |||
| #define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER | |||
There was a problem hiding this comment.
Please ignore the changes to the file Marlin/Configuration.h
There was a problem hiding this comment.
Even if I ignore the changes, git won't.
You may revert these changes in your branch, clean up excess commits with git rebase -i HEAD~5, and use git push -f to update the PR, if you wish. Otherwise I would need to do all of that myself.
|
Tests look good. What to do next: |
| @@ -318,10 +318,10 @@ FORCE_INLINE void _draw_heater_status(const uint8_t x, const int8_t heater) { | |||
| #endif | |||
|
|
|||
| if (PAGE_UNDER(7)) | |||
| _draw_centered_temp((isBed ? thermalManager.degTargetBed() : thermalManager.degTargetHotend(heater)) + 0.5, x, 7); | |||
| _draw_centered_temp((isBed ? thermalManager.degTargetBed() : thermalManager.degTargetHotend(heater)) + 0.5, x, 7-1); | |||
There was a problem hiding this comment.
@yhfudev Is it possible here for the glyph to extend below pixel row 6 and into pixel row 7?
|
|
||
| if (PAGE_CONTAINS(21, 28)) | ||
| _draw_centered_temp((isBed ? thermalManager.degBed() : thermalManager.degHotend(heater)) + 0.5, x, 28); | ||
| _draw_centered_temp((isBed ? thermalManager.degBed() : thermalManager.degHotend(heater)) + 0.5, x, 28-1); |
There was a problem hiding this comment.
@yhfudev Is it possible here for the glyph to extend below pixel row 27 and into pixel row 28?
I ask because, if the position of the glyph changes we should alter PAGE_CONTAINS(21, 28) too.
There was a problem hiding this comment.
The y offset of the glyph is 6, is because of the value yoff of the FONTBOUNDINGBOX in BDF file is set to -2. The height of the glyph is 8, so we have to set the position to (8-2) so that the glyph can be showed in full at the top.
There was a problem hiding this comment.
So I don't think you need to change the PAGE_CONTAINS(21, 28).
| @@ -174,7 +173,7 @@ static int fontgroup_cb_draw_u8g (void *userdata, const font_t *fnt_current, con | |||
| assert(NULL != userdata); | |||
| if (pdata->fnt_prev != fnt_current) { | |||
| u8g_SetFont(pdata->pu8g, fnt_current); | |||
| u8g_SetFontPosBottom(pdata->pu8g); | |||
| //u8g_SetFontPosBottom(pdata->pu8g); | |||
I think that's a good idea. If the tools were implemented in Java, Javascript, Python, or GNU shell scripting, they'd be more portable. Simple C programs are of course also acceptable, if they use common libs and do simple stream-in/stream-out style. |
Maybe. The "small" font doesn't end up being much smaller than the normal font, so I'm less worried about it. But the big edit font might be useful for some vendors / setups that want to have a more custom appearance for the edit screens. |
