deploy config poc #684
Open
deploy config poc #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uint256 platformFees = (totalPrice * platformFeeBps) / MAX_BPS; | ||
| address _mintFeeManager = mintFeeManager; |
There was a problem hiding this comment.
dont really need this var
| pragma solidity ^0.8.20; | ||
|
|
||
| interface IMintFeeManager { | ||
| function calculatePlatformFeeAndRecipient( |
There was a problem hiding this comment.
where is the actual implementation of this?
also was thinking of keeping the naming a bit generic, drop the 'mint' from it since it can be for all sorts of fees
|
|
||
| interface IMintFeeManager { | ||
| function calculatePlatformFeeAndRecipient( | ||
| uint256 _price |
There was a problem hiding this comment.
here i think it makes sense to send some sort of 'source' or 'id' that the calling contract would pass. For example for drop721 it could pass "dropERC721". that way the fee manager can decide to change the fees for different contracts based on that passed 'id'.
ie. maybe marketplace has a diff fee than a drop erc721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.