Renames for consistency accross executors

[joaquim-verges]

Summary by CodeRabbit

• Refactor

  • Standardized field names from hash to transaction_hash across multiple transaction-related structures and methods for improved consistency.
  • Updated string labels for various execution stages and confirmation steps for clearer user-facing messages.
  • Adjusted serialization names for certain options to use uppercase for consistency in serialized formats.

• Style

  • Improved formatting and naming conventions for better readability in user-facing outputs.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This set of changes standardizes naming conventions across multiple modules, primarily renaming the hash field to transaction_hash in transaction-related structs and methods. It also updates serialization attributes to use uppercase "EOA" and alters several string return values for executor stage names and display implementations, ensuring consistency in string representations throughout the codebase.

Changes

File(s)	Change Summary
core/src/execution_options/mod.rs, core/src/signer.rs	Serialization rename for enum variant changed from "eoa" to "EOA" in SpecificExecutionOptions and SigningOptions.
executors/src/eip7702_executor/send.rs, executors/src/external_bundler/send.rs	stage_name() return value changed from "prepare_and_send" to "send" in executor stage handlers.
executors/src/external_bundler/confirm.rs	stage_name() return value changed from "confirmation" to "confirm" in confirmation handler.
executors/src/eoa/events.rs	Display for EoaExecutorStage::Confirmation changed from "confirmation" to "confirm"; fixed transaction hash source in error payload.
executors/src/eoa/store/borrowed.rs, executors/src/eoa/store/hydrate.rs, executors/src/eoa/store/mod.rs, executors/src/eoa/store/submitted.rs, executors/src/eoa/worker/confirm.rs, executors/src/eoa/worker/transaction.rs	Renamed field hash to transaction_hash in all relevant structs, methods, and logic for transaction handling, hydration, storage, and confirmation.
executors/src/eoa/store/submitted.rs	Updated method bodies and struct fields to use transaction_hash instead of hash throughout submitted transaction code.
executors/src/eoa/worker/confirm.rs	Renamed hash to transaction_hash in ConfirmedTransactionWithRichReceipt and related logic.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ExecutorStage
    participant TransactionStore

    Client->>ExecutorStage: Call stage_name()
    ExecutorStage-->>Client: Returns "send" or "confirm"

    Client->>TransactionStore: Store transaction with transaction_hash
    TransactionStore-->>Client: Acknowledge storage

    Client->>TransactionStore: Retrieve transaction by transaction_hash
    TransactionStore-->>Client: Return transaction data

Loading

sequenceDiagram
    participant Serializer
    participant EnumVariant

    Serializer->>EnumVariant: Serialize SpecificExecutionOptions::EOA
    EnumVariant-->>Serializer: Use "EOA" as serialized value

    Serializer->>EnumVariant: Serialize SigningOptions::Eoa
    EnumVariant-->>Serializer: Use "EOA" as serialized value

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5feaa18 and 55fa59a.

📒 Files selected for processing (12)

• core/src/execution_options/mod.rs (3 hunks)
• core/src/signer.rs (1 hunks)
• executors/src/eip7702_executor/send.rs (1 hunks)
• executors/src/eoa/events.rs (2 hunks)
• executors/src/eoa/store/borrowed.rs (1 hunks)
• executors/src/eoa/store/hydrate.rs (1 hunks)
• executors/src/eoa/store/mod.rs (2 hunks)
• executors/src/eoa/store/submitted.rs (8 hunks)
• executors/src/eoa/worker/confirm.rs (7 hunks)
• executors/src/eoa/worker/transaction.rs (1 hunks)
• executors/src/external_bundler/confirm.rs (1 hunks)
• executors/src/external_bundler/send.rs (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.