Skip to content

Refactor EIP-7702 sender details and improve webhook error handling #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Refactor EIP-7702 sender details and improve webhook error handling #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions executors/src/eip7702_executor/confirm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,5 +345,3 @@ where
}
}
}

// --- Helper Functions ---
4 changes: 2 additions & 2 deletions executors/src/eip7702_executor/send.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ pub enum Eip7702Sender {
#[serde(rename_all = "camelCase")]
SessionKey {
session_key_address: Address,
account_address: Address,
eoa_address: Address,
},
}

Expand Down Expand Up @@ -302,7 +302,7 @@ where
let sender_details = match session_key_target_address {
Some(target_address) => Eip7702Sender::SessionKey {
session_key_address: owner_address,
account_address: target_address,
eoa_address: target_address,
},
None => Eip7702Sender::Owner {
eoa_address: owner_address,
Expand Down
3 changes: 2 additions & 1 deletion executors/src/webhook/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use engine_core::execution_options::WebhookOptions;
use hex;
use hmac::{Hmac, Mac};
use reqwest::header::{HeaderMap, HeaderName, HeaderValue};
use reqwest::StatusCode;
use serde::{Deserialize, Serialize};
use twmq::error::TwmqError;
use twmq::hooks::TransactionContext;
Expand Down Expand Up @@ -285,7 +286,7 @@ impl DurableExecution for WebhookJobHandler {
body_preview: error_body_preview,
};

if status.is_server_error() || status.as_u16() == 429 {
if status.is_server_error() || status == StatusCode::TOO_MANY_REQUESTS {
if job.job.attempts < self.retry_config.max_attempts {
let delay_ms = self.retry_config.initial_delay_ms as f64
* self
Expand Down