Skip to content

When deleting contract sub, don't delete underlying webhook #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 11, 2025

Unexpected behavior, we have apis for deleting webhooks


PR-Codex overview

This PR focuses on simplifying the removeContractSubscription function by removing the deletion of a webhook associated with a contract subscription.

Detailed summary

  • Removed the import statement for deleteWebhook.
  • Eliminated the conditional check and call to deleteWebhook based on contractSubscription.webhookId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Unexpected behavior, we have apis for deleting webhooks

Signed-off-by: Firekeeper <0xFirekeeper@gmail.com>
Copy link

zeet-co bot commented Apr 11, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-fireke-8520e2.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr self-requested a review April 11, 2025 19:46
@d4mr d4mr merged commit bc6a6d9 into main Apr 11, 2025
5 of 6 checks passed
@d4mr d4mr deleted the firekeeper/improve-contract-sub-deletion branch April 11, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants