[SDK] Add option to NOT load NFT metadata #1823
Conversation
|
kien-ngo
added
the
DO NOT MERGE
| type: "ERC721", | ||
| supply: "1", | ||
| }; | ||
| return nft as T extends true | undefined ? NFT : NFTWithoutMetadata; |
There was a problem hiding this comment.
I couldn't find a way to solve this without using type assertion.
Googling leads to this open issue: microsoft/TypeScript#33912
| @@ -425,11 +444,10 @@ export class Erc721< | |||
| public async getOwned( | |||
| walletAddress?: AddressOrEns, | |||
| queryParams?: QueryAllParams, | |||
| ) { | |||
| ): Promise<NFT[] | NFTWithoutMetadata[]> { | |||
There was a problem hiding this comment.
Can't wrap my head around how to deal with the typings here
|
@joaquim-verges The code is not complete but I'd love to have a review before I go too far. I have left a few comments above in the code ^ |
…0 to 4.2.1 (#1823) build(deps-dev): bump @trivago/prettier-plugin-sort-imports Bumps [@trivago/prettier-plugin-sort-imports](https://github.com/trivago/prettier-plugin-sort-imports) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/trivago/prettier-plugin-sort-imports/releases) - [Changelog](https://github.com/trivago/prettier-plugin-sort-imports/blob/main/CHANGELOG.md) - [Commits](trivago/prettier-plugin-sort-imports@v4.2.0...v4.2.1) --- updated-dependencies: - dependency-name: "@trivago/prettier-plugin-sort-imports" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Problem solved
Short description of the bug fixed or feature added
Changes made
How to test