Skip to content

[Portal] Fix: update sidebar overflow behavior in DocLayout component #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

Axyl1410
Copy link
Contributor

@Axyl1410 Axyl1410 commented Jul 21, 2025

[Portal] Fix: update sidebar overflow behavior in DocLayout component

Fix sidebar cant be scroll in portal document


PR-Codex overview

This PR focuses on improving the layout and styling of components within the application, particularly enhancing the sidebar behavior and adjusting padding within the header and search elements.

Detailed summary

  • In DocLayout.tsx, changed overflow-y-hidden to overflow-y-auto no-scrollbar for better sidebar scrolling.
  • In DocSearch.tsx, adjusted padding from py-1 to p-1 in the search button container.
  • In Header.tsx, updated padding from pt-4 px-4 pb-4 to p-4 for a more uniform header appearance.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Enabled vertical scrolling in the sidebar on extra-large screens, allowing users to scroll through sidebar content when it overflows while keeping the scrollbar visually hidden.
    • Simplified header padding for a cleaner layout.
    • Adjusted spacing inside the search button for improved visual consistency.

@Axyl1410 Axyl1410 requested review from a team as code owners July 21, 2025 05:47
Copy link

changeset-bot bot commented Jul 21, 2025

⚠️ No Changeset found

Latest commit: b51780e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Jul 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented Jul 21, 2025

@Axyl1410 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

The changes update padding classes in the Header and DocSearch components for simpler, uniform padding. Additionally, the sidebar container in DocLayout is modified to allow vertical scrolling with a hidden scrollbar on extra-large screens. No changes to exported or public entities occur.

Changes

File Change Summary
apps/portal/src/components/Layouts/DocLayout.tsx Changed sidebar container overflow-y from "hidden" to "auto" and added "no-scrollbar" class for xl screens
apps/portal/src/app/Header.tsx Replaced separate padding classes (pt-4 px-4 pb-4) with uniform padding class p-4 on header element
apps/portal/src/components/others/DocSearch.tsx Changed padding on div inside desktop search button from px-1 py-1 to uniform p-1

Estimated code review effort

1 (~10 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9845fcf and b51780e.

📒 Files selected for processing (2)
  • apps/portal/src/app/Header.tsx (1 hunks)
  • apps/portal/src/components/others/DocSearch.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • apps/portal/src/components/others/DocSearch.tsx
  • apps/portal/src/app/Header.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jul 21, 2025
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:07pm

@MananTank
Copy link
Member

@Axyl1410 Thanks for your contribution!
I've updated the code to hide scrollbars

@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Jul 21, 2025
Copy link
Contributor

graphite-app bot commented Jul 21, 2025

Merge activity

  • Jul 21, 6:11 PM UTC: @Axyl1410 we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jul 21, 2025
@joaquim-verges
Copy link
Member

thank you for this @Axyl1410 !

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.03%. Comparing base (8133fab) to head (b51780e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7653       +/-   ##
===========================================
- Coverage   56.36%   36.03%   -20.33%     
===========================================
  Files         908      901        -7     
  Lines       58244    57747      -497     
  Branches     4226     2379     -1847     
===========================================
- Hits        32829    20812    -12017     
- Misses      25307    36858    +11551     
+ Partials      108       77       -31     
Flag Coverage Δ
packages 36.03% <ø> (-20.33%) ⬇️

see 301 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 8d3b9c6 into thirdweb-dev:main Jul 21, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants