-
Notifications
You must be signed in to change notification settings - Fork 563
[Portal] Fix: update sidebar overflow behavior in DocLayout component #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Portal] Fix: update sidebar overflow behavior in DocLayout component #7653
Conversation
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
@Axyl1410 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes update padding classes in the Header and DocSearch components for simpler, uniform padding. Additionally, the sidebar container in DocLayout is modified to allow vertical scrolling with a hidden scrollbar on extra-large screens. No changes to exported or public entities occur. Changes
Estimated code review effort1 (~10 minutes) 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Axyl1410 Thanks for your contribution! |
f8f20e6
to
9845fcf
Compare
thank you for this @Axyl1410 ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7653 +/- ##
===========================================
- Coverage 56.36% 36.03% -20.33%
===========================================
Files 908 901 -7
Lines 58244 57747 -497
Branches 4226 2379 -1847
===========================================
- Hits 32829 20812 -12017
- Misses 25307 36858 +11551
+ Partials 108 77 -31
🚀 New features to boost your workflow:
|
[Portal] Fix: update sidebar overflow behavior in DocLayout component
Fix sidebar cant be scroll in portal document
PR-Codex overview
This PR focuses on improving the layout and styling of components within the application, particularly enhancing the sidebar behavior and adjusting padding within the header and search elements.
Detailed summary
DocLayout.tsx
, changedoverflow-y-hidden
tooverflow-y-auto no-scrollbar
for better sidebar scrolling.DocSearch.tsx
, adjusted padding frompy-1
top-1
in the search button container.Header.tsx
, updated padding frompt-4 px-4 pb-4
top-4
for a more uniform header appearance.Summary by CodeRabbit