-
Notifications
You must be signed in to change notification settings - Fork 603
Dashboard: Remove playwright tests, checkly #8269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Remove playwright tests, checkly #8269
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
b56ce1a
to
c934102
Compare
147a353
to
0083e3b
Compare
WalkthroughRemoved the dashboard E2E testing stack: Checkly and Playwright configuration files, all Playwright test suites and helpers, the E2E README, and related npm devDependencies and scripts from the dashboard app. (47 words) Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (8)
🧰 Additional context used📓 Path-based instructions (1)**/package.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
0083e3b
to
1a97ce8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8269 +/- ##
=======================================
Coverage 54.89% 54.90%
=======================================
Files 919 919
Lines 60613 60613
Branches 4115 4115
=======================================
+ Hits 33273 33278 +5
+ Misses 27239 27234 -5
Partials 101 101
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on the removal of various test files and configurations related to the `dashboard` application, alongside updates to the `package.json` and `pnpm-lock.yaml` files to reflect changes in dependencies. ### Detailed summary - Deleted multiple test files in `apps/dashboard/tests`. - Removed configuration files: `setup.ts`, `README.md`, `checkly.config.ts`, and `playwright.config.ts`. - Updated `package.json` to remove dependencies related to `checkly` and `playwright`. - Adjusted `pnpm-lock.yaml` to reflect the removal of certain packages and their dependencies. > The following files were skipped due to too many changes: `pnpm-lock.yaml` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Removed end-to-end testing infrastructure, configuration, helper utilities, test runner scripts, and related dev dependencies from the dashboard app. * **Documentation** * Deleted the dashboard E2E testing README and related test documentation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1a97ce8
to
bf90104
Compare
PR-Codex overview
This PR focuses on cleaning up the
apps/dashboard
project by removing unnecessary test files, configuration files, and dependencies, particularly related tocheckly
andplaywright
. It also updates thepackage.json
andpnpm-lock.yaml
files accordingly.Detailed summary
apps/dashboard/tests/
checkly.config.ts
,playwright.config.ts
checkly
and@playwright/test
dependencies frompackage.json
pnpm-lock.yaml
to reflect the removals and changes in dependencies.Summary by CodeRabbit