Skip to content

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 16, 2025


PR-Codex overview

This PR focuses on cleaning up the apps/dashboard project by removing unnecessary test files, configuration files, and dependencies, particularly related to checkly and playwright. It also updates the package.json and pnpm-lock.yaml files accordingly.

Detailed summary

  • Deleted various test files in apps/dashboard/tests/
  • Removed configuration files: checkly.config.ts, playwright.config.ts
  • Removed checkly and @playwright/test dependencies from package.json
  • Updated pnpm-lock.yaml to reflect the removals and changes in dependencies.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Removed end-to-end testing setup, associated test suites, helper utilities, test runner scripts, and related dev dependencies from the dashboard app.
  • Documentation
    • Deleted the dashboard E2E testing README and related test documentation.

Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: bf90104

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 16, 2025 9:16pm
nebula Ready Ready Preview Comment Oct 16, 2025 9:16pm
thirdweb_playground Ready Ready Preview Comment Oct 16, 2025 9:16pm
thirdweb-www Ready Ready Preview Comment Oct 16, 2025 9:16pm
wallet-ui Ready Ready Preview Comment Oct 16, 2025 9:16pm

@MananTank MananTank marked this pull request as ready for review October 16, 2025 19:14
@MananTank MananTank requested review from a team as code owners October 16, 2025 19:14
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2025
Copy link
Member Author

MananTank commented Oct 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the base branch from mny-269 to graphite-base/8269 October 16, 2025 19:14
@MananTank MananTank force-pushed the 10-17-dashboard_remove_playwright_tests_checkly branch from 147a353 to 0083e3b Compare October 16, 2025 19:14
@MananTank MananTank changed the base branch from graphite-base/8269 to main October 16, 2025 19:14
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

Removed the dashboard E2E testing stack: Checkly and Playwright configuration files, all Playwright test suites and helpers, the E2E README, and related npm devDependencies and scripts from the dashboard app. (47 words)

Changes

Cohort / File(s) Summary
Test configuration
apps/dashboard/checkly.config.ts, apps/dashboard/playwright.config.ts
Deleted Checkly and Playwright configuration modules and their default exports (checks, browser projects, reporters, webServer, CLI and top-level metadata).
Package configuration
apps/dashboard/package.json
Removed devDependencies (@playwright/test, checkly) and removed npm scripts related to Playwright/Checkly (e.g., playwright, update-checkly).
Playwright test suites
apps/dashboard/tests/chain-page.spec.ts, apps/dashboard/tests/contract-page.spec.ts, apps/dashboard/tests/homepage.spec.ts, apps/dashboard/tests/publisher-page.spec.ts
Deleted Playwright test files and their test suites/assertions for chain, contract, homepage, and publisher pages.
Test utilities & docs
apps/dashboard/tests/setup.ts, apps/dashboard/tests/README.md
Removed test helper functions (getBaseURL, waitForPageLoad) and the E2E testing README documentation.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not follow the required template structure. All the key sections from the repository template—including the formatted title suggestion, Linear issue tag, "Notes for the reviewer," and "How to test"—remain as empty placeholder comments rather than being filled in by the author. While a PR-Codex generated summary is included that provides a helpful overview of what was deleted, this does not substitute for the author completing the required template sections. The description is largely incomplete relative to the stated requirements. The author should complete the required template sections with meaningful content. Specifically, fill in "Notes for the reviewer" section to explain why these tests and Checkly configurations are being removed, and complete the "How to test" section with appropriate testing instructions or justification. If there is a related Linear issue (TEAM-0000 format), it should also be included. While the PR-Codex overview is informative, the author's own context and notes are essential for reviewers to understand the rationale behind this cleanup.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Dashboard: Remove playwright tests, checkly" is concise, specific, and directly summarizes the main purpose of the changeset. It clearly indicates that the PR removes Playwright tests and Checkly configuration from the dashboard application, which aligns perfectly with the actual changes shown in the raw summary—deletion of multiple test files, configuration files (playwright.config.ts, checkly.config.ts), setup.ts, and removal of related dependencies from package.json. A teammate scanning the git history would immediately understand the primary change without ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-17-dashboard_remove_playwright_tests_checkly

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1a97ce8 and bf90104.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (9)
  • apps/dashboard/checkly.config.ts (0 hunks)
  • apps/dashboard/package.json (1 hunks)
  • apps/dashboard/playwright.config.ts (0 hunks)
  • apps/dashboard/tests/README.md (0 hunks)
  • apps/dashboard/tests/chain-page.spec.ts (0 hunks)
  • apps/dashboard/tests/contract-page.spec.ts (0 hunks)
  • apps/dashboard/tests/homepage.spec.ts (0 hunks)
  • apps/dashboard/tests/publisher-page.spec.ts (0 hunks)
  • apps/dashboard/tests/setup.ts (0 hunks)
💤 Files with no reviewable changes (8)
  • apps/dashboard/tests/setup.ts
  • apps/dashboard/tests/homepage.spec.ts
  • apps/dashboard/tests/README.md
  • apps/dashboard/playwright.config.ts
  • apps/dashboard/checkly.config.ts
  • apps/dashboard/tests/chain-page.spec.ts
  • apps/dashboard/tests/contract-page.spec.ts
  • apps/dashboard/tests/publisher-page.spec.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Track bundle budgets via package.json#size-limit

Files:

  • apps/dashboard/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/package.json (1)

80-128: Clean removal of Playwright and Checkly dev dependencies and scripts.

The devDependencies and scripts sections correctly reflect the removal of @playwright/test, checkly, the "playwright" script, and "update-checkly" script. JSON structure is valid with no unintended removals. Verification confirms no lingering references to these packages in downstream configurations or CI workflows.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.90%. Comparing base (8003e93) to head (bf90104).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8269   +/-   ##
=======================================
  Coverage   54.89%   54.90%           
=======================================
  Files         919      919           
  Lines       60613    60613           
  Branches     4115     4115           
=======================================
+ Hits        33273    33278    +5     
+ Misses      27239    27234    -5     
  Partials      101      101           
Flag Coverage Δ
packages 54.90% <ø> (+<0.01%) ⬆️
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Oct 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.51 KB (0%) 1.3 s (0%) 115 ms (+144.05% 🔺) 1.5 s
thirdweb (cjs) 365.68 KB (0%) 7.4 s (0%) 505 ms (+5.35% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 77 ms (+1367.61% 🔺) 191 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 46 ms (+4027.11% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 31 ms (+333.5% 🔺) 413 ms

Copy link
Contributor

graphite-app bot commented Oct 16, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on the removal of various test files and configurations related to the `dashboard` application, alongside updates to the `package.json` and `pnpm-lock.yaml` files to reflect changes in dependencies.

### Detailed summary
- Deleted multiple test files in `apps/dashboard/tests`.
- Removed configuration files: `setup.ts`, `README.md`, `checkly.config.ts`, and `playwright.config.ts`.
- Updated `package.json` to remove dependencies related to `checkly` and `playwright`.
- Adjusted `pnpm-lock.yaml` to reflect the removal of certain packages and their dependencies.

> The following files were skipped due to too many changes: `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Chores**
  * Removed end-to-end testing infrastructure, configuration, helper utilities, test runner scripts, and related dev dependencies from the dashboard app.
* **Documentation**
  * Deleted the dashboard E2E testing README and related test documentation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants