This repository was archived by the owner on Aug 30, 2022. It is now read-only.
[Breaking change] Multichain SDK #477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
… async (#492) * Multichain SDK - override chain for any contract * multi chain registry and factory * pass optional chain to sdk.getX() and fix signer RPC switch when using private keys * fix all the tests * fix vote test
joaquim-verges
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated provider and signer logic, which gives the following setup API:
and we still have of course:
That separation is what enables the much nicer multichain support and mismatch detection. So now if you're not connected to the right chain, it'll give a really clean error message instead of the current random ones we throw