Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

expose sdk.getBalance(anyAddress) #484

Merged
merged 1 commit into from
Jun 24, 2022
Merged

expose sdk.getBalance(anyAddress) #484

merged 1 commit into from
Jun 24, 2022

Conversation

joaquim-verges
Copy link
Member

No description provided.

@jnsdls
Copy link
Member

jnsdls commented Jun 24, 2022

@joaquim-verges in other places where we have the concept of getBalance we allow u to both check for NATIVE_TOKEN and any ERC20 balances. is this also the case here? It looks like this is only native token currently?

@joaquim-verges
Copy link
Member Author

I thought about it, but for ERC20 we kinda overlap with tokenContract.balanceOf() so felt unneeded. Can revisit later though

@joaquim-verges joaquim-verges merged commit 860232e into main Jun 24, 2022
@joaquim-verges joaquim-verges deleted the joaquim/sdk_balance branch June 24, 2022 03:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges @jnsdls