Initial Refactor #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build.cs: remove redundant definitions, simplify library import, format - uplugin: remove engine version in source code - module.h/cpp: remove empty .h file definition and set cpp file as defaultmoduleimpl
* move FFIResult helper to struct * chain result * replace deprecated character conversion macros
Migrated handle to actual handle created separate bp / cpp functions with bp split enum returns Created async task for oauth login Refsctored many inputs to unreal native
* Proper pure/callable flags per type * Some cpp functions moved to handle * bp wrappers of handle functions moved to function library * function library created to interface with standard UE nodes * example actors cleaned up * Root macro library created for expansion
|
Hey @dirtycajunrice - first of all I want to say this is a fantastic refactor, highly appreciated! To get this to the finish line I added a few things I noticed in here while testing. Furthermore, in The Level_Thirdweb_OAuth also appears to always throw invalid wallet type for me, were you able to run the levels successfully? Thanks again! |
* UTF8 string cast fixed * Generated copyright fixed * Error message for wallet type revised * SignMessage Generalized * `LocalWallet` param renamed to `PersonalWallet` Added: * Widget interactive examples started
|
Addressed all review points, and added beginnings of widget example ThirdwebExamplesClip.mp4 |
* Added remaining smart wallet logic * created bp functions for new rust calls * (regression) reverted encoding back to old macro until additional info can be gleaned * attach validators to private key page * various minor things
Fixed typo for gasless and authenticate
Update otp to use single input monospaced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: