Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mac & Linux + InternalWebBrowser #4

Merged
merged 37 commits into from
Aug 30, 2024

Conversation

dirtycajunrice
Copy link
Collaborator

  • Updated readme with more descriptive information
  • Moved from the self-hosted http flow to an internal WebBrowser flow
  • Added additional blueprint utility functions
  • custom WebBrowser widget and userwidget
  • Additional binaries added for next platform support stage

dirtycajunrice and others added 30 commits July 27, 2024 09:46
- Build.cs: remove redundant definitions, simplify library import, format
- uplugin: remove engine version in source code
- module.h/cpp: remove empty .h file definition and set cpp file as defaultmoduleimpl
* move FFIResult helper to struct
* chain result
* replace deprecated character conversion macros
Migrated handle to actual handle
created separate bp / cpp functions with bp split enum returns
Created async task for oauth login
Refsctored many inputs to unreal native
* Proper pure/callable flags per type
* Some cpp functions moved to handle
* bp wrappers of handle functions moved to function library
* function library created to interface with standard UE nodes
* example actors cleaned up
* Root macro library created for expansion
* UTF8 string cast fixed
* Generated copyright fixed
* Error message for wallet type revised
* SignMessage Generalized
* `LocalWallet` param renamed to `PersonalWallet`
Added:
* Widget interactive examples started
* Wrap runtime settings in trimmed empty or null check
Enhance:
* Create textbox widget for OTP entry
* Create otp widget for managing all numbers with validation
* resurface the otp verification widget to match new style
* Added remaining smart wallet logic
* created bp functions for new rust calls
* (regression) reverted encoding back to old macro until additional info can be gleaned
* attach validators to private key page
* various minor things
Fixed typo for gasless and authenticate
Update otp to use single input monospaced
# Conflicts:
#	Thirdweb.uplugin
# Conflicts:
#	Thirdweb.uplugin
@0xFirekeeper
Copy link
Member

Apple login appears to have a transparent background now, might need extra options? Believe it wasn't like this in initial tests
745c8d092c36dd0400801b1f260df7bf

"PlatformAllowList": [
"Win64",
"Mac",
"Linux"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should LinuxArm64 be added here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should the mobile static libs be removed from the package for the time being?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing then maybe

@0xFirekeeper
Copy link
Member

Unimportant: bunch of TCHAR_TO_UTF8 left
Otherwise looking good overall, good work!

@0xFirekeeper 0xFirekeeper merged commit 43ac9e8 into main Aug 30, 2024
@0xFirekeeper 0xFirekeeper deleted the feat/cross-platform branch August 30, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants