Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for passing fd to fs.file* only Node 5.x #17

Closed
thisconnect opened this issue Dec 15, 2015 · 2 comments
Closed

add tests for passing fd to fs.file* only Node 5.x #17

thisconnect opened this issue Dec 15, 2015 · 2 comments
Labels
enhancement
Milestone
v2.0.0

Comments

@thisconnect
Copy link
Owner

nodejs/node#3163
@thisconnect thisconnect added this to the v1.1.0 milestone Dec 15, 2015
@thisconnect thisconnect removed this from the v1.1.0 milestone May 11, 2016
@thisconnect
Copy link
Owner Author

on hold until Node.js 6.x LTS in October

@thisconnect thisconnect added this to the v2.0.0 milestone May 31, 2017
thisconnect pushed a commit that referenced this issue May 31, 2017
starts adding fd test (#17)
5073756
@thisconnect
Copy link
Owner Author

also 1e0daaa

thisconnect pushed a commit that referenced this issue May 31, 2017
Tests (#29)
a8c2b82 
* changes var to const

* changes tape to test

* more destructs

* cleanup

* changes ok to true

* starts adding fd test (#17)

* adds missing fd tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@thisconnect