Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown expansion name in localStorage crashes the app #3

Closed
thisisrandy opened this issue Feb 18, 2024 · 1 comment
Closed

Unknown expansion name in localStorage crashes the app #3

thisisrandy opened this issue Feb 18, 2024 · 1 comment
Assignees

Comments

@thisisrandy
Copy link
Owner

When an altered or garbage expansion name is present in localStorage, an uncaught error is thrown when attempting to load that board. This is especially problematic for mobile users, who don't normally have the ability to surgically clean localStorage and instead will have to delete an unknown amount of browsing history wholesale.

There should be logic present to test if the saved expansion name is valid and use a default value if not.

@thisisrandy
Copy link
Owner Author

There's a similar issue if a bad shared board expansion name is passed. We'll handle that in this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant