Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements made to scrolling feature #1

Closed
wants to merge 2 commits into from

Conversation

kellym
Copy link

@kellym kellym commented Jul 7, 2011

The scrolling feature was limited to the current screen, and so any serious long-page scrolling came to a halt pretty quickly. Also, when you released the scroll button, the mouse would move to a new location, even if it was set to return to the original position.

I fixed it by moving the cursor to the middle of the screen and resetting the cursor to the middle whenever it neared the screen edge. In addition, I added the code to reset the cursor to its original position.

Let me know what you think-- I'd at least like to get the fix updated on some level in the ubuntu repos. Thanks!

@thjaeger
Copy link
Owner

Thanks for your patch. I'm not too fond of the
move-the-mouse-to-the-middle-of-the-screen workaround since it wreaks
havoc on absolute devices (most SDL apps are unusable on tablets for
precisely this reason). The correct way to solve this problem is to use
raw events. I'm working on this right now, I'll let you know when I
have something to test.

Tom

On 07/07/2011 03:31 PM, kellym wrote:

The scrolling feature was limited to the current screen, and so any serious long-page scrolling came to a halt pretty quickly. Also, when you released the scroll button, the mouse would move to a new location, even if it was set to return to the original position.

I fixed it by moving the cursor to the middle of the screen and resetting the cursor to the middle whenever it neared the screen edge. In addition, I added the code to reset the cursor to its original position.

Let me know what you think-- I'd at least like to get the fix updated on some level in the ubuntu repos. Thanks!

@kellym
Copy link
Author

kellym commented Jul 28, 2011

I agree with you, my patch is probably more of a quick fix than anything. I had tried to do some research on working with raw events since that had been my original intention, but being a web developer without a whole lot of software dev experience, I don't yet have the knowledge of dealing with those sorts of things. I'm looking forward to seeing how you solve it. Thanks!

kelly

@thjaeger
Copy link
Owner

Kelly,

I've pushed this code to git now, in case you want to check it out.
I'll probably release a new version this weekend.

Thanks,
Tom

On 07/28/2011 11:20 AM, kellym wrote:

I agree with you, my patch is probably more of a quick fix than anything. I had tried to do some research on working with raw events since that had been my original intention, but being a web developer without a whole lot of software dev experience, I don't yet have the knowledge of dealing with those sorts of things. I'm looking forward to seeing how you solve it. Thanks!

kelly

@kellym
Copy link
Author

kellym commented Aug 10, 2011

Much better looking than my attempt. Thanks for the work on this project, I appreciate it.

Thanks,

kelly

@kellym kellym closed this Aug 10, 2011
MRWITEK referenced this pull request in MRWITEK/easystroke Jun 18, 2022
MRWITEK referenced this pull request in MRWITEK/easystroke Jun 18, 2022
MRWITEK referenced this pull request in MRWITEK/easystroke Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants