Skip to content

fixed issues in python script to work with Python 3 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed issues in python script to work with Python 3 #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gyp_learnuv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ def host_arch():

def compiler_version():
proc = subprocess.Popen(CC.split() + ['--version'], stdout=subprocess.PIPE)
is_clang = 'clang' in proc.communicate()[0].split('\n')[0]
is_clang = 'clang' in proc.communicate()[0].decode().split('\n')[0]
proc = subprocess.Popen(CC.split() + ['-dumpfullversion','-dumpversion'], stdout=subprocess.PIPE)
version = proc.communicate()[0].split('.')
version = proc.communicate()[0].decode().split('.')
version = map(int, version[:2])
version = tuple(version)
return (version, is_clang)
Expand All @@ -53,7 +53,7 @@ def compiler_version():
def run_gyp(args):
rc = gyp.main(args)
if rc != 0:
print 'Error running GYP'
print('Error running GYP')
sys.exit(rc)


Expand Down Expand Up @@ -117,5 +117,5 @@ def run_gyp(args):
args.append('-Dlearnuv_config=' + learnuv_config)

gyp_args = list(args)
print gyp_args
print(gyp_args)
run_gyp(gyp_args)