Merge pull request #146 from kkHAIKE/array_set_fix

fix Array case bug for Set
thoas · Mar 16, 2022 · dfe9213 · dfe9213
2 parents 38b2794 + b15e3d5
commit dfe9213
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/assign.go b/assign.go
@@ -77,7 +77,7 @@ func set(inValue reflect.Value, setValue reflect.Value, parts []string) error {
 			}
 			inValue = fValue
 			i++
-		case reflect.Slice | reflect.Array:
+		case reflect.Slice, reflect.Array:
 			// set all its elements
 			length := inValue.Len()
 			for j := 0; j < length; j++ {

diff --git a/assign_test.go b/assign_test.go
@@ -295,6 +295,13 @@ func TestSet_SlicePassDirectly(t *testing.T) {
 			SetVal:   "val",
 			Expected: []*Bar{{Name: "val"}, {Name: "val"}},
 		},
+		// Array of ptr
+		{
+			Original: [2]*Bar{{Name: "a"}, {Name: "b"}},
+			Path:     "Name",
+			SetVal:   "val",
+			Expected: [2]*Bar{{Name: "val"}, {Name: "val"}},
+		},
 		// slice of struct
 		{
 			Original: []Bar{{Name: "a"}, {Name: "b"}},