prevent breaking oscar

thofma · Feb 24, 2023 · 1d82f9e · 1d82f9e
1 parent ed86f4f
commit 1d82f9e
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/Deprecations.jl b/src/Deprecations.jl
@@ -32,9 +32,9 @@
 
 @deprecate automorphisms(x::LocalField, y::Union{FlintPadicField, FlintQadicField, LocalField}) automorphism_list(x, y)
 
-# Deprecated during 0.17.*
+# Deprecated during 0.18.*
 
-@deprecate orthogonal_sum(x::T, y::T) where T <: Union{TorQuadModule, ZLat, AbstractSpace, ZGenus, ZpGenus, HermGenus, HermLocalGenus, QuadGenus, QuadLocalGenus, JorDec, LocalQuadSpaceCls, QuadSpaceCls} direct_sum(x, y)
+@deprecate orthogonal_sum(x::T, y::T) where T <: Union{AbstractSpace, ZGenus, ZpGenus, HermGenus, HermLocalGenus, QuadGenus, QuadLocalGenus, JorDec, LocalQuadSpaceCls, QuadSpaceCls} direct_sum(x, y)
 
 # Things that moved to Nemo
 

diff --git a/src/QuadForm/Quad/ZLattices.jl b/src/QuadForm/Quad/ZLattices.jl
@@ -299,6 +299,13 @@ function orthogonal_submodule(L::ZLat, S::ZLat)
  return lattice(V, Ks*B)
 end
 
+### Deprecated: should be removed once fixed in Oscar!!
+
+function orthogonal_sum(x::ZLat, y::ZLat)
+ z, inj = direct_sum(x, y)
+ return z, inj[1], inj[2]
+end
+
 ################################################################################
 #
 # String I/O

diff --git a/src/QuadForm/Torsion.jl b/src/QuadForm/Torsion.jl
@@ -1885,6 +1885,16 @@ end
 
 biproduct(x::Vararg{TorQuadModule}) = biproduct(collect(x))
 
+### Deprecated: should be removed once fixed in Oscar!!
+
+function orthogonal_sum(x::TorQuadModule, y::TorQuadModule)
+ z, inj = direct_sum(x, y)
+ return z, inj[1], inj[2]
+end
+export orthogonal_sum
+
+_orthogonal_sum_with_injections_and_projections(x::Vector{TorQuadModule}) = biproduct(x)
+
 ###############################################################################
 #
 # Primary/elementary torsion quadratic module