Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External URLs are prefixed with blog url #19

Merged
merged 3 commits into from
Nov 24, 2012
Merged

External URLs are prefixed with blog url #19

merged 3 commits into from
Nov 24, 2012

Conversation

thom4parisot
Copy link
Owner

Assume my-blog-url is "http://myblog.com/"
I want to load a font-file from another server named 'http://somewhere-else.com/'

@font-face{
font-family:"Familyname";
src: url("http://somewhere-else.com/my-font.woff);
}

will be compiled to:

@font-face{
font-family:"Familyname";
src: url("http://myblog.com/http://somewhere-else.com/my-font.woff);
}

commenting line 251 in lib/Plugin.class.php (starts with add_filter('wp-less_stylesheet_save'…) did the job for me at first sight, but i don't see yet, what else might be broken.

@ghost ghost assigned thom4parisot Nov 13, 2012
@thom4parisot
Copy link
Owner

Indeed, it's an axis I have to improve. Currently, the URL filter is not properly detecting anything that's not relative.
It's mainly due I built the plugin for my own usage.

Thanks for reporting, time to improve now :-)

thom4parisot pushed a commit that referenced this pull request Nov 24, 2012
External URLs are prefixed with blog url
@thom4parisot thom4parisot merged commit 38ac83a into master Nov 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant