Added a few features to allow improved filtering and some docs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable problematic oem features as they can cause false positives on dell hardware
|
Hi Giles, sorry for my late reply. Thank you for your patches. Although we do not actively maintain the v2 plugin anymore (we recommend to use the perl-based version https://github.com/thomas-krenn/check_ipmi_sensor_v3), I can add your patches to the v2 code. The only commit that I would reject is e85f6ed (Exit OK when command isn't found). In case that the plugin cannot run successfully, the user should not think that everything is fine. Could you remove this commit or switch it back to the original behaviour? And please move the new file ignore-critical-failures to the contribs dir. Thanks and best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.