Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Throw error when "maxConcurrency" is non-numeric/undefined #243

Closed
Discartyptics opened this issue Jan 14, 2020 · 1 comment · Fixed by #279
Closed

Suggestion: Throw error when "maxConcurrency" is non-numeric/undefined #243

Discartyptics opened this issue Jan 14, 2020 · 1 comment · Fixed by #279
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Discartyptics
Copy link

If the "maxConcurrency" option in Cluster.launch is undefined somehow, Cluster never fires any workers and appears to stand still without any errors or warnings.

In my code, I had set the "maxConcurrency" option to a variable, and while refactoring code accidentally set the value to undefined - causing Cluster to never process any queue items.

Maybe Cluster could trigger a warning or error if "maxConcurrency" is set to something non-numeric?

@thomasdondorf thomasdondorf added enhancement New feature or request help wanted Extra attention is needed labels Feb 11, 2020
@thomasdondorf
Copy link
Owner

Yes, this looks like an easy fix (simple if check in the constructor). Welcoming any pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants