Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node and deps #7

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

NiharR27
Copy link
Contributor

Updating node12 to node20 to get rid of the warning on ci:

The following actions uses node12 which is deprecated and will be forced to run on node16: thomaseizinger/create-release@1.0.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

OR

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: thomaseizinger/create-release@1.0.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@NiharR027
Copy link

cc @thomaseizinger - created a brand new PR. lemme know if all good. Thnx 🙏

Copy link
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much! 🙏

@thomaseizinger thomaseizinger merged commit f897c34 into thomaseizinger:master Aug 27, 2024
2 checks passed
@thomaseizinger
Copy link
Owner

I'd appreciate if you could test-drive latest master wherever you use this. If everything is good, I am happy to make a release after!

@NiharR027
Copy link

NiharR027 commented Aug 27, 2024

@thomaseizinger - can confirm that it went fine without any warnings/errors:

Screenshot 2024-08-27 at 1 15 03 PM
Screenshot 2024-08-27 at 1 15 28 PM
Screenshot 2024-08-27 at 1 15 43 PM

@NiharR27
Copy link
Contributor Author

@thomaseizinger - thanks 🙏 for merging. Any chance we can do a mini release with a new version for this? If not then I will just use master for now. Cheers.

@thomaseizinger
Copy link
Owner

Yeah was about to make one.

@thomaseizinger
Copy link
Owner

Done!

@NiharR27
Copy link
Contributor Author

NiharR27 commented Sep 1, 2024

danke :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants