-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile popup fix for HA 2023.7.3 #619
base: master
Are you sure you want to change the base?
Conversation
This is not working for me @raymercury. I edited /config/custom_components/browser_mod/browser_mod.js with the correct code as listed by the changes on github and this has had no effect on my popup bug. Let me know if I'm doing this wrong. |
@ve1koz111 I think modifying the existing JS file doesn't work. You may need to install a modified version of browser_mod integration using HACS. Use HACS to install a test version which includes the fix: |
@raymercury Thanks so much for fixing this bug, it was driving me bonkers! |
@raymercury Thanks so much! |
@thomasloven can we get this PR merged ? |
Uninstalled in HACS, uninstalled in Devices and services. Installed your repository, and after restart installed in devices and services. |
Fix is working great. Is it possible to merge it please? |
👍 |
@thomasloven could you please merge this pr to solve our problem? Thank you! |
This would make the popup look different from native Home Assistant popups, like the more-info dialog. |
Yeah but thats what some ppl want instead of a popup card which use 100% height ^^ maybe you can add it with a Option in the Settings so people can decide which style they want? Full-Screen or the Smaller one |
@thomasloven: I see what you mean, but all I want is browser_mod to respect its own size/style options, as mentioned in #639 The default might as well stay as it is. |
@thomasloven I think this is needed. I did it manually for now otherwise my wife rejected my latest home changes... She's a tough reviewer... |
Hi, replying here hoping you see this. Would it be possible for you to update your fork of browser_mod as well, so it works with HA 2024.7+? Your mobille fix sadly is stuck on an older browser_mod version, which has broken popups with 2024.7+. So in order to use popups again, I have to use the official browser_mod, which doesn't have the mobile fix. |
#606 #617
Around 2023.7.3 mobile popups got really longgggg.
Happens for iOS, android, and web browser.