Skip to content

Commit

Permalink
Fix #134 and fix #135 Avoid masking of tolower
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasp85 committed Mar 14, 2019
1 parent 2229721 commit 89de705
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ggforce (development version)

- Fixed a regression in `geom_sina()` where the computation would fail with a
warning due to `tolower()` being masked (#134, #135).

#ggforce 0.2.1

Expand Down
2 changes: 1 addition & 1 deletion R/sina.R
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ calc_bw <- function(x, bw) {
if (length(x) < 2)
stop("need at least 2 points to select a bandwidth automatically", call. = FALSE)
bw <- switch(
tolower(bw),
base::tolower(bw),
nrd0 = stats::bw.nrd0(x),
nrd = stats::bw.nrd(x),
ucv = stats::bw.ucv(x),
Expand Down

0 comments on commit 89de705

Please sign in to comment.