feat(python of provider): Stop using provider.provider #1772
Conversation
…#319 Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 89 89
Lines 3344 3344
=======================================
Hits 2901 2901
Misses 343 343
Partials 100 100 ☔ View full report in Codecov by Sentry. |
|
Waiting for the SDK to be released and we will release this PR when available. |
| @@ -5,4 +5,7 @@ | |||
|
|
|||
| @dataclass | |||
| class GoFeatureFlagMetadata(Metadata): | |||
| def __init__(self): | |||
| pass | |||
|
|
|||
There was a problem hiding this comment.
note: this is probably not necessary
There was a problem hiding this comment.
I've added it because pycharm was complaining 😮💨
|
FYI provider state should be handled by the Python SDK according to the latest OF spec. There is no longer a need to expose a |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Thanks for the heads up @federicobond, I've removed the usage of get_status from the code. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
changed the title
thomaspoignant
changed the title
|
* Stop using provider.provider as mentionned in open-feature/python-sdk#319 Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> * Remove usage of status Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> * remove unused init Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> --------- Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Description
Stop using provider.provider as mentioned in open-feature/python-sdk#319
Next steps:
Checklist