Support creating static ArcStr
's at runtime (leaking them)
#55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this a while ago, then didn't need it, but it may be useful to others.
The main drawback is that it adds a branch to refcount manipulation, but that should be a wash (the function is already doing atomic RMWs, which are likely more costly than a the branching most of the time).
On the positive side, it makes it so we no longer need to abort on refcount overflow -- we can simply transition the string to static (leak it).
I've also updated some deps and may do a bit of other cleanup while I'm here.
EDIT: this is now mostly cleanup.