Bump to 1.6.0

[fitzgen]

No description provided.

[fitzgen]

It seems like installing / running miri is failing in CI, but when I do it locally, it works out fine. Any idea what's going on here @RalfJung? Should CI be doing cargo clean before running miri tests?

[RalfJung]

This is odd, I have not seen that failure before. It does install the latest xargo, I am not sure what else there might be that could be causing trouble.

Somehow the rustc-std-workspace-std patch does not seem to kick in?

[RalfJung]

@alexcrichton something odd seems to happen, there's a version 1.0.1 of rustc-std-workspace-std on crates.io but the rustc workspace only contains a version 1.0.0? It looks like that version mismatch makes cargo pick the crates.io-version even though xargo set up a patch to use the local version instead.

[fitzgen]

Hm, since you don't know the fix, I'm tempted to configure CI to allow this job to fail, with the hopes that this bug eventually gets fixed upstream :-/

Do you have a better plan than that?

[RalfJung]

Do you have a better plan than that?

If my analysis is correct, the bug is outside of your or my control, so no, I do not have a better plan.
Hopefully @alexcrichton has an idea.

[alexcrichton]

Should be fixed in rust-lang/rust#64320

[RalfJung]

@alexcrichton that was quick, thanks!

[fitzgen]

Hm ok so I retriggered these tests now that there are new nightlies out with Alex's fix, and now there are issues about backtrace:

error[E0432]: unresolved import `crate::sys_common::backtrace`

  --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:98:24

   |

98 | use crate::sys_common::backtrace::{output_filename, lock};

   |                        ^^^^^^^^^ could not find `backtrace` in `sys_common`

error[E0432]: unresolved import `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:100:5

    |

100 | use backtrace::BytesOrWideString;

    |     ^^^^^^^^^ help: a similar path exists: `crate::backtrace`

    |

    = note: `use` statements changed in Rust 2018; read more at <https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html>

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:146:12

    |

146 |     frame: backtrace::Frame,

    |            ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:231:13

    |

231 |             backtrace::trace_unsynchronized(|frame| {

    |             ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:285:35

    |

285 |             (&capture.frames[..], backtrace::PrintFmt::Full)

    |                                   ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:287:55

    |

287 |             (&capture.frames[capture.actual_start..], backtrace::PrintFmt::Short)

    |                                                       ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:299:21

    |

299 |         let mut f = backtrace::BacktraceFmt::new(fmt, style, &mut print_path);

    |                     ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:309:54

    |

309 |                         symbol.name.as_ref().map(|b| backtrace::SymbolName::new(b)),

    |                                                      ^^^^^^^^^ use of undeclared type or module `backtrace`

error[E0433]: failed to resolve: use of undeclared type or module `backtrace`

   --> /home/travis/.rustup/toolchains/nightly-2019-09-12-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/backtrace.rs:339:17

    |

339 |                 backtrace::resolve_frame_unsynchronized(&frame.frame, |symbol| {

    |                 ^^^^^^^^^ use of undeclared type or module `backtrace`

error: aborting due to 9 previous errors

At this point, I'm going to mark the miri tests as "allow fail" until this stuff gets fixed upstream.

[RalfJung]

Yeah just saw these "backtrace" things on our CI as well. So far I have no idea what that is about.

Really the biggest problem is that rust-lang/rust#60301 is still open, which means that we ship Miri even if we know the tests are broken.