Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri fixes (various) #57

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Miri fixes (various) #57

merged 4 commits into from
Jan 9, 2023

Conversation

thomcc
Copy link
Owner

@thomcc thomcc commented Jan 9, 2023

This incorporates the changes from #54 and #55 (thanks @clubby789 and @human-0 for those fixes!), but with some changes that aren't worth waiting on review back and forth.

It also re-enables miri in CI, and removes #[cfg_attr(miri, ignore)] from some tests.

This required bumping MSRV to 1.42 which is still very old, so I don't think it matters realistically.

@thomcc thomcc merged commit b92091a into master Jan 9, 2023
@thomcc thomcc deleted the thomcc/miri-fixes branch January 9, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant