-
-
Notifications
You must be signed in to change notification settings - Fork 96
Add timeout functionality for hooks with 5-minute default timeout #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
749a2e8
Initial plan
Copilot 038d07d
Implement hook timeout functionality with 5-minute default timeout
Copilot 3788f8e
Update public API snapshots to approve hook timeout changes
Copilot fa96072
Merge branch 'main' into copilot/fix-2890
thomhurst dc3e186
Implement proper hook timeout functionality with event receiver pattern
claude[bot] f576397
Refactor hook methods to share unified HookMethod base class
claude[bot] d0c57d3
Fix hook timeout implementation for PR #2891
thomhurst 4e58d8e
fix: Update InstanceHookMethod property from ClassType to InitClassTy…
thomhurst c723ee3
fix: Add HookRegisteredContext and update Timeout handling in hook me…
thomhurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using TUnit.Core.Hooks; | ||
|
|
||
| namespace TUnit.Core; | ||
|
|
||
| /// <summary> | ||
| /// Context for hook registration phase | ||
| /// </summary> | ||
| public class HookRegisteredContext | ||
| { | ||
| private TimeSpan? _timeout; | ||
|
|
||
| public HookMethod HookMethod { get; } | ||
| public string HookName => HookMethod.Name; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the timeout for this hook | ||
| /// </summary> | ||
| public TimeSpan? Timeout | ||
| { | ||
| get => _timeout; | ||
| set => _timeout = value; | ||
| } | ||
|
|
||
| public HookRegisteredContext(HookMethod hookMethod) | ||
| { | ||
| HookMethod = hookMethod; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.