Skip to content

Conversation

@thomhurst
Copy link
Owner

This PR contains the following updates:

Package Type Update Change
Microsoft.NET.Test.Sdk nuget patch 18.0.0 -> 18.0.1

Release Notes

microsoft/vstest (Microsoft.NET.Test.Sdk)

v18.0.1

What's Changed

Fixing an issue with loading covrun64.dll on systems that have .NET 10 SDK installed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/code-coverage-dynamic-native-instrumentation

Internal changes

Full Changelog: microsoft/vstest@v18.0.0...v18.0.1


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file PATCH renovate-bot labels Nov 11, 2025
@thomhurst thomhurst enabled auto-merge (squash) November 11, 2025 10:10
@claude
Copy link
Contributor

claude bot commented Nov 11, 2025

Claude finished @thomhurst's task —— View job


PR Review: Microsoft.NET.Test.Sdk Update to 18.0.1

Todo List:

  • Read and analyze the modified file (Directory.Packages.props)
  • Review the dependency update and release notes
  • Assess compatibility and potential impacts
  • Check for any TUnit-specific considerations
  • Provide comprehensive review feedback

Review Summary

This PR updates Microsoft.NET.Test.Sdk from 18.0.0 to 18.0.1 in the centralized package management file. This is a safe and recommended update.

Code Quality & Best Practices ✅

The change follows excellent practices:

  • ✅ Uses centralized package management (Directory.Packages.props)
  • ✅ Single line change, minimal impact
  • ✅ Automated dependency management via Renovate

Bug Fixes & Stability ✅

This patch version addresses a critical compatibility issue:

  • Primary Fix: Resolves covrun64.dll loading issues on systems with .NET 10 SDK installed
  • Mitigation: Disables DynamicNative instrumentation by default to prevent runtime failures
  • Scope: Only affects code coverage instrumentation, not core test execution

Performance Considerations ✅

Positive Impact:

  • Disabling DynamicNative instrumentation by default may slightly improve test startup time
  • No negative performance implications expected
  • Code coverage functionality remains intact through alternative instrumentation methods

Security Concerns ✅

  • Low Risk: Patch version with targeted bug fixes
  • Source: Official Microsoft package with established security practices
  • Change Scope: Limited to test infrastructure, not production code

TUnit-Specific Assessment ✅

Excellent Compatibility:

  • TUnit uses Microsoft.Testing.Platform (line 45: Version="2.0.1") as its primary testing infrastructure
  • Microsoft.NET.Test.Sdk is used alongside for broader ecosystem compatibility
  • Both testing platforms coexist well and this update won't affect TUnit's core functionality
  • TUnit's dual-mode execution (source-generated + reflection) is unaffected

No Breaking Changes: This update only affects:

  • Code coverage instrumentation behavior
  • VSTest platform compatibility (which TUnit doesn't primarily rely on)

Test Coverage Impact ⚠️

Action Required:
While the update is safe, teams using code coverage should verify:

  • Code coverage reports still generate correctly after deployment
  • Alternative instrumentation methods work as expected
  • CI/CD pipelines with coverage collection continue functioning

Recommendation ✅

Approve and Merge: This is a well-targeted bug fix that:

  1. Resolves compatibility issues with .NET 10 SDK
  2. Maintains all existing functionality
  3. Follows semantic versioning appropriately
  4. Poses minimal risk to TUnit's operations

The automerge configuration is appropriate for this type of maintenance update.

@thomhurst thomhurst merged commit c06c1c5 into main Nov 11, 2025
12 of 13 checks passed
@thomhurst thomhurst deleted the renovate/microsoft.net.test.sdk-18.x branch November 11, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file PATCH renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants