Skip to content

Conversation

@thomhurst
Copy link
Owner

This PR contains the following updates:

Package Type Update Change
Aspire.AppHost.Sdk msbuild-sdk major 9.5.2 -> 13.0.0
Aspire.Hosting.AppHost nuget major 9.5.2 -> 13.0.0
Aspire.Hosting.Redis nuget major 9.5.2 -> 13.0.0
Aspire.Hosting.Testing nuget major 9.5.2 -> 13.0.0
Aspire.StackExchange.Redis.OutputCaching nuget major 9.5.2 -> 13.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file MAJOR renovate-bot labels Nov 11, 2025
@thomhurst thomhurst enabled auto-merge (squash) November 11, 2025 16:10
@claude
Copy link
Contributor

claude bot commented Nov 11, 2025

Claude finished @thomhurst's task —— View job


PR Review: Aspire v13 Major Update

Review Checklist:

  • Read repository guidelines (CLAUDE.md)
  • Examine changed .csproj files
  • Analyze Aspire version changes (9.5.2 → 13.0.0)
  • Check for potential breaking changes
  • Evaluate test coverage impact
  • Assess security and performance considerations
  • Provide comprehensive feedback

Analysis Summary

This PR updates .NET Aspire from version 9.5.2 to 13.0.0 across the TUnit template projects. This is a significant major version jump that requires careful consideration.

Positive Aspects

  1. Clean Package Updates: All Aspire packages are consistently updated across template projects
  2. Template-Only Changes: Changes are isolated to template content, not core TUnit functionality
  3. Consistent Versioning: All related packages (AppHost.Sdk, Hosting.AppHost, Hosting.Redis, etc.) are updated together

⚠️ Concerns & Recommendations

1. Major Version Jump Risk
  • Issue: Jumping from v9.5.2 → v13.0.0 skips versions 10, 11, and 12
  • Risk: Potential breaking changes in API surface, behavior, or dependencies
  • Recommendation: Review Aspire release notes for versions 10-13 for breaking changes
2. Missing Template Testing
  • Issue: No verification that templates still work with new Aspire version
  • Files Affected:
    • TUnit.Aspire.Starter/ExampleNamespace.TestProject/Tests/ApiTests.cs:1
    • TUnit.Aspire.Test/IntegrationTest1.cs:1
  • Recommendation: Test template generation and compilation
3. Potential API Compatibility Issues

Current template code uses:

// GlobalSetup.cs:21
var appHost = await DistributedApplicationTestingBuilder.CreateAsync<Projects.ExampleNamespace_AppHost>();
appHost.Services.ConfigureHttpClientDefaults(clientBuilder => { ... });
  • Risk: These APIs may have changed between v9 and v13
  • Recommendation: Verify API compatibility

🔍 Detailed File Analysis

File Changes Risk Level
ExampleNamespace.AppHost.csproj SDK + 2 packages updated Medium - Core hosting changes
ExampleNamespace.TestProject.csproj Testing package updated High - Test framework integration
ExampleNamespace.WebApp.csproj Output caching updated Low - Isolated feature
ExampleNamespace.csproj Testing package updated High - Test framework integration

🛡️ Security Considerations

  • Positive: Updates to latest version include security patches
  • Note: No obvious security concerns in template code
  • Recommendation: Verify no new security warnings in updated packages

📈 Performance Considerations

  • Unknown Impact: Major version updates may include performance changes
  • Recommendation: Benchmark template performance if this is a concern
  • Note: Templates are for development scaffolding, not production critical paths

TUnit Integration Compatibility

  • Good: No changes to TUnit package references in templates
  • Good: Test code patterns remain consistent with TUnit best practices
  • Good: No dual-mode implementation required (template changes only)

📋 Required Actions Before Merge

  1. Test Template Generation:

    dotnet new tunit-aspire-starter -n TestApp
    cd TestApp
    dotnet build
    dotnet test
  2. Verify API Compatibility: Check that DistributedApplicationTestingBuilder.CreateAsync still works

  3. Review Aspire v13 Breaking Changes: Consult official release notes

  4. Consider Gradual Update: If issues found, consider updating to v10/v11 first

🎯 Verdict

Conditional Approval - The changes look structurally sound, but the major version jump requires verification that:

  • Templates still compile and run
  • Aspire testing APIs remain compatible
  • No unexpected breaking changes affect TUnit integration

The risk is moderate because these are template files that users will generate, and any issues would affect their experience with TUnit + Aspire integration.


@thomhurst thomhurst merged commit c829562 into main Nov 11, 2025
12 of 13 checks passed
@thomhurst thomhurst deleted the renovate/major-aspire branch November 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MAJOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants