-
-
Notifications
You must be signed in to change notification settings - Fork 108
Clarify TUnit0046 diagnostic message for data source return types #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clarify TUnit0046 return type description
Clarify TUnit0046 diagnostic message for data source return types
Nov 14, 2025
This was referenced Nov 16, 2025
This was referenced Dec 17, 2025
This was referenced Dec 24, 2025
This was referenced Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TUnit0046 analyzer warns when data source methods return reference types directly instead of wrapped in
Func<T>, but the diagnostic message was cryptic: "Return aFunc<T>rather than a<T>"Users couldn't understand what
<T>meant or whyFunc<T>was required.Changes
Updated diagnostic messages in
Resources.resx:Data source should return Func<T> for reference typesData source method should return Func<T> for reference type parameters (other than string) to ensure proper test isolationFunc<T>defers object creation to prevent shared state between testsUpdated
AnalyzerReleases.Shipped.md:Example
Before:
After:
The message now explicitly states what types trigger the rule (reference types except string) and explains the rationale (test isolation).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.