Skip to content

fix: JUnit reporter was encoding xml files in UTF-16 instead of UTF-8 #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
Dec 6, 2025
Merged

fix: JUnit reporter was encoding xml files in UTF-16 instead of UTF-8 #4001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b935f7
fix: JUnit reporter
rchoffardet Dec 6, 2025
9fb5c9d
Enforce UTF-8 instead of UTF-16
rchoffardet Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions TUnit.Engine/Xml/JUnitXmlWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public static string GenerateXml(
?.FrameworkDisplayName
?? RuntimeInformation.FrameworkDescription;

using var stringWriter = new StringWriter();
using var stringWriter = new Utf8StringWriter();
var settings = new XmlWriterSettings
{
Indent = true,
Expand Down Expand Up @@ -62,7 +62,7 @@ public static string GenerateXml(

xmlWriter.WriteEndElement(); // testsuites
xmlWriter.WriteEndDocument();

xmlWriter.Flush();
return stringWriter.ToString();
}

Expand Down Expand Up @@ -341,6 +341,11 @@ private static TestSummary CalculateSummary(IEnumerable<TestNodeUpdateMessage> t
}
}

file sealed class Utf8StringWriter : StringWriter
{
public override Encoding Encoding => Encoding.UTF8;
}

internal sealed class TestSummary
{
public int Total { get; set; }
Expand Down
Loading