Skip to content

test: add xUnit migration tests for Assert.Empty and using directive removal #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 15, 2026
Merged

test: add xUnit migration tests for Assert.Empty and using directive removal #4430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 147 additions & 0 deletions TUnit.Analyzers.Tests/XUnitMigrationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,6 +1364,153 @@ public async Task TypeAssertions()
);
}

[Test]
public async Task XUnit_Assert_Empty_List_Converted()
{
await CodeFixer
.VerifyCodeFixAsync(
"""
{|#0:using Xunit;
using System.Collections.Generic;

public class MyClass
{
[Fact]
public void MyTest()
{
var items = new List<string>();
Assert.Empty(items);
}
}|}
""",
Verifier.Diagnostic(Rules.XunitMigration).WithLocation(0),
"""
using System.Collections.Generic;
using System.Threading.Tasks;

public class MyClass
{
[Test]
public async Task MyTest()
{
var items = new List<string>();
await Assert.That(items).IsEmpty();
}
}
""",
ConfigureXUnitTest
);
}

[Test]
public async Task XUnit_Assert_NotEmpty_List_Converted()
{
await CodeFixer
.VerifyCodeFixAsync(
"""
{|#0:using Xunit;
using System.Collections.Generic;

public class MyClass
{
[Fact]
public void MyTest()
{
var items = new List<string> { "item" };
Assert.NotEmpty(items);
}
}|}
""",
Verifier.Diagnostic(Rules.XunitMigration).WithLocation(0),
"""
using System.Collections.Generic;
using System.Threading.Tasks;

public class MyClass
{
[Test]
public async Task MyTest()
{
var items = new List<string> { "item" };
await Assert.That(items).IsNotEmpty();
}
}
""",
ConfigureXUnitTest
);
}

[Test]
public async Task XUnit_Assert_Empty_Array_Converted()
{
await CodeFixer
.VerifyCodeFixAsync(
"""
{|#0:using Xunit;

public class MyClass
{
[Fact]
public void MyTest()
{
var items = new string[0];
Assert.Empty(items);
}
}|}
""",
Verifier.Diagnostic(Rules.XunitMigration).WithLocation(0),
"""
using System.Threading.Tasks;

public class MyClass
{
[Test]
public async Task MyTest()
{
var items = new string[0];
await Assert.That(items).IsEmpty();
}
}
""",
ConfigureXUnitTest
);
}

[Test]
public async Task XUnit_Using_Directive_Removed()
{
await CodeFixer
.VerifyCodeFixAsync(
"""
{|#0:using Xunit;
using Xunit.Abstractions;

public class MyClass
{
[Fact]
public void MyTest()
{
Assert.True(true);
}
}|}
""",
Verifier.Diagnostic(Rules.XunitMigration).WithLocation(0),
"""
using System.Threading.Tasks;

public class MyClass
{
[Test]
public async Task MyTest()
{
await Assert.That(true).IsTrue();
}
}
""",
ConfigureXUnitTest
);
}

private static void ConfigureXUnitTest(Verifier.Test test)
{
var globalUsings = ("GlobalUsings.cs", SourceText.From("global using Xunit;"));
Expand Down
Loading