perf: remove unused value and early return in DedThreadExe#4517
Merged
thomhurst merged 1 commit intothomhurst:mainfrom Feb 3, 2026
Merged
perf: remove unused value and early return in DedThreadExe#4517thomhurst merged 1 commit intothomhurst:mainfrom
DedThreadExe#4517thomhurst merged 1 commit intothomhurst:mainfrom
Conversation
Owner
|
Looks like ya posted the same image for before and after |
Contributor
Author
Yeah, I've fixed it, but semi abadoned this PR when I realised the savings weren't adding up and I had no idea how to prove that line 82 did anything. |
Contributor
Author
|
This should help a little, don't know how much though |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Review Summary: This PR makes clean performance optimizations that align well with TUnit's "Performance First" principle:
All changes are semantically equivalent to the original code while reducing memory allocations in hot-path test execution code. |
This was referenced Feb 5, 2026
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DedicatedThreadTaskScheduler _taskSchedulerfieldExecuteAsyncsyncTask.Factory.StartNewsyncBefore
After